ktmud opened a new pull request #15699:
URL: https://github.com/apache/superset/pull/15699


   ### SUMMARY
   
   This will be one of the many PRs to address perf issues raised in #15518 .
   
   Currently the Dashboard page will wait for both `datasets` and `charts` data 
to start rendering, however the datasets data are only used in filter 
indicators and filter boxes and should not block us from rendering other 
charts. In our case, the `datasets` endpoint is often much slower because we 
have a giant single-source-of-truth datasource with thousands of metrics and 
columns.
   
   Unblocking rendering from the datasets endpoint should speed up the page 
rendering a little bit. In our use case, it's often a matter of a full second.
   
   It's not easy to simply remove `datasources` from Dashboard state as that 
would involve letting the filter indicators and filter box fetching datasource 
metadata themselves.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A
   
   ### TESTING INSTRUCTIONS
   
   Go to dashboard page, make sure everything still renders correctly.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to