etr2460 commented on issue #15694:
URL: https://github.com/apache/superset/issues/15694#issuecomment-880704988
A couple thoughts about the change here:
1. I believe the checkbox exists as the query run to generate the
autocomplete can be very expensive on large tables, especially those with many
partitions. It runs a query like:
```sql
SELECT DISTINCT "column_name" AS "column_name"
FROM "table_name"
LIMIT 10000
```
which can be quite expensive, or return an error for our Presto setup (since
you can filter on calculated columns/metrics which can contain arbitrarily
complex sql queries). This is a bit less of a concern since you can still type
in a value while the filter is running the query, but i'm not sure how the
error state is handled here. We should verify that before changing the default.
I'd also be concerned about removing the control entirely, since in some cases
we probably want the ability to prevent superset from spamming the data
warehouse with expensive, long running, synchronous queries .
2. A bigger concern I have is that the autocomplete only returns 10000
results and in a seemingly arbitrary order. This means that it can be difficult
to select the actual value you want. See the gif below of what happens when you
type in a value and press enter:
Before making this the default, could we try to address some of these UX
issues?
3. Finally, if we change the default here, I assume it's changing the
default for newly created datasets. Would we want to migrate already existing
datasets to default the checkbox to checked too?
Basically, I'm a bit worried about the increased query load this could add
to our warehouse, error handling, and the UX of the current feature. While the
happy path with small datasets seems to be fully functional, it would be good
to address some of the large deployment edge cases before changing the default.
Hope this helps!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
