ktmud commented on issue #15694: URL: https://github.com/apache/superset/issues/15694#issuecomment-881636615
> Appreciate the detailed feedback/info on the concerns @etr2460. I also agree with @graceguo-supercat on the configurability. I also agree with @junlincc that it may make sense to start lumping some behaviors like this under a single flag. I'm not sure if we still have concerns about the "Open in Explore" link target, but I'll use it in these examples... > > We could either be forward looking, or backwards compatible with the flag, e.g.: > > * `BETA_UX_BEHAVIOR = True` could do things like opening Explore in the same window, and turning on autocomplete from this example > * `LEGACY_BEHAVIOR = False` could do exactly the inverse > > Either way, it could be overridden, but maybe the Legacy branding makes more sense, as turning on a Beta flag by default sounds weird. > > But would it make sense to folks to group this sort of thing under a single flag, or are we not worried about a potential proliferation of flags for single UX/UI items like these? +1 on grouping new UX behaviors under a single feature flags. But may I suggest calling them `EXPERIMENTAL_UX_BEHAVIORS` and keep them off by default? We can keep add new features or changing default behaviors _without_ this flag and only move them into the flag when it becomes a contentious point. Most of the time, when people don't want a feature, it is because there are some shortcomings in the implementation---even though they may benefit the majority of Superset users. For example, the open chart in same window would be nice to have even for Airbnb if cmd + click is possible AND navigating back to dashboard does not reload the whole page; select options default on is good for everyone if it won't cause db stress for large datasets & it can show all options... I think it's fair to keep them behind a "EXPERIMENTAL" flag until we address these addressable shortcomings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
