michael-s-molina edited a comment on pull request #15925: URL: https://github.com/apache/superset/pull/15925#issuecomment-889076781
> Hello @michael-s-molina. Thanks for the fix. > > I have noticed that when changing an existing filter and then creating a new one, when saving it says "1 unsaved filter". However, I would expect that to say "2 unsaved filters" as I did changes to two filters that were not saved yet. This is a minor thing though. > > scroll.inconsist.mp4 @geido I made a change to make the cancel message more generic because tracking exactly which filter changed would require additional logic. Also because the previous strategy of listing the names of the filters that changed is not suitable when the number of changed filters is high. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
