ktmud opened a new pull request #16053: URL: https://github.com/apache/superset/pull/16053
### SUMMARY Fix a 500 error on the `/dashboard/<dashboardId>/datasets` API caused by an incorrect nested list comprehension introduced by https://github.com/apache/superset/pull/15993 . Updated the test case to cover this case. In dashboards where a slice has the `y` metric set (e.g. a NVD3 timeseries chart), the `/datasets` API will return 500. However, most of the time if will not break the dashboard, since this API is almost only used in FilterBox and filter indicators. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS 1. Test adding a NVD3 Timeseries chart to the dashboard 2. You may see 500 error in base but not error after the fix ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
