stephenLYZ commented on a change in pull request #17881: URL: https://github.com/apache/superset/pull/17881#discussion_r782103703
########## File path: superset/connectors/base/models.py ########## @@ -396,7 +397,11 @@ def handle_single_value(value: Optional[FilterValue]) -> Optional[FilterValue]: ): return datetime.utcfromtimestamp(value / 1000) if isinstance(value, str): - value = value.strip("\t\n'\"") + value = value.strip("\t\n") + + quotes_value = re.findall(r"['|\"](.*?)['|\"]", value) + if len(quotes_value) == 1 and quotes_value[0] == value.strip("'\""): + value = value.strip("'\"") Review comment: Agree. It was added in https://github.com/apache/superset/pull/4651. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org