etr2460 opened a new pull request #18021:
URL: https://github.com/apache/superset/pull/18021


   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   When the results in SQL Lab has more than 50 columns, we don't do any 
filtering. This isn't obvious from the UI though, since the filter box is still 
editable. This change disables the filter box and adds context to the 
placeholder when the result set has more than 50 columns
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   TODO once spinning up a test env
   
   ### TESTING INSTRUCTIONS
   Verify in testenv that results with > 50 columns have a disabled filter box
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @michael-s-molina @ktmud @graceguo-supercat 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to