hughhhh commented on a change in pull request #18093:
URL: https://github.com/apache/superset/pull/18093#discussion_r788107579
##########
File path: superset/connectors/base/models.py
##########
@@ -110,6 +110,8 @@ def name(self) -> str:
params = Column(String(1000))
perm = Column(String(1000))
schema_perm = Column(String(1000))
+ is_managed_externally = Column(Boolean, default=False)
+ external_url = Column(Text, nullable=True)
Review comment:
couldnt we just compute the `is_managed_externally` based upon the if
`external_url` ? instead of having a seperate column?
```
@property
def is_managed_externally(self) -> Bool:
return self. external_url is not None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
