[GitHub] [superset] kgabryje opened a new pull request #18108: feat(explore): more toast feedback on user actions

[GitBox]

kgabryje opened a new pull request #18108:
URL: https://github.com/apache/superset/pull/18108


   ### SUMMARY
   This PR adds new toast messages as a feedback to user actions in Explore.
   
   1. Success/danger toast when copying chart url to clipboard succeeded/failed
   2. Success toast when user edited chart properties in Explore or Chart List 
views
   3. Change toast type from info to success when user saves chart
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1773" alt="Screenshot 2022-01-20 at 12 35 10" 
src="https://user-images.githubusercontent.com/15073128/150338619-40e93ea9-4
   <img width="1773" alt="Screenshot 2022-01-20 at 12 42 01" 
src="https://user-images.githubusercontent.com/15073128/150338654-3862f400-5565-4c2d-b501-f2b75a17885d.png";>
   66c-46c5-8de6-d0dc8f72942a.png">
   <img width="1773" alt="Screenshot 2022-01-20 at 13 29 23" 
src="https://user-images.githubusercontent.com/15073128/150338946-417fc4bf-3242-481b-9241-2546038f6ff7.png";>
   
   
https://user-images.githubusercontent.com/15073128/150338958-3af79662-eb83-4c1b-a4e3-98d4c1fd5cb2.mov
   
   ### TESTING INSTRUCTIONS
   1. Copy chart url to clipboard by clicking button in the top right corner of 
the explore view. Verify that toast message appears.
   2. Edit chart properties via Edit Properties modal in Explore or Chart List 
view. Verify that toast message appears.
   3. Save/overwrite chart. Verify that success toast message appears.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC @yousoph @rusackas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org