zhaoyongjie commented on a change in pull request #17881:
URL: https://github.com/apache/superset/pull/17881#discussion_r794403553
##########
File path: tests/integration_tests/sqla_models_tests.py
##########
@@ -475,80 +476,133 @@ def test_labels_expected_on_mutated_query(self):
db.session.delete(database)
db.session.commit()
- def test_values_for_column(self):
+
+@pytest.fixture
+def text_column_table():
+ with app.app_context():
table = SqlaTable(
- table_name="test_null_in_column",
+ table_name="text_column_table",
sql=(
"SELECT 'foo' as foo "
"UNION SELECT '' "
"UNION SELECT NULL "
- "UNION SELECT 'null'"
+ "UNION SELECT 'null' "
+ "UNION SELECT '\"text in double quotes\"' "
+ "UNION SELECT '''text in single quotes''' "
+ "UNION SELECT 'double quotes \" in text' "
+ "UNION SELECT 'single quotes '' in text' "
),
database=get_example_database(),
)
TableColumn(column_name="foo", type="VARCHAR(255)", table=table)
SqlMetric(metric_name="count", expression="count(*)", table=table)
+ yield table
Review comment:
**table** wasn't persisted so we no need **delete** command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
