villebro commented on a change in pull request #18569:
URL: https://github.com/apache/superset/pull/18569#discussion_r799628205
##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -97,6 +114,126 @@ export const RowCount = ({
/>
);
+enum FormatPickerValue {
+ formatted,
+ epoch,
+}
+
+const FormatPicker = ({
+ onChange,
+ value,
+}: {
+ onChange: any;
+ value: FormatPickerValue;
+}) => (
+ <Radio.Group value={value} onChange={onChange}>
+ <Space direction="vertical">
+ <Radio value={FormatPickerValue.epoch}>{t('Epoch')}</Radio>
+ <Radio value={FormatPickerValue.formatted}>{t('Formatted date')}</Radio>
+ </Space>
+ </Radio.Group>
+);
Review comment:
Sounds good - the "Formatted date" comment was mostly me trying to sound
clever 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
