betodealmeida commented on a change in pull request #18562:
URL: https://github.com/apache/superset/pull/18562#discussion_r800991944
##########
File path: tests/unit_tests/dashboards/commands/importers/v1/utils_test.py
##########
@@ -49,8 +49,10 @@ def test_update_id_refs_immune_missing( # pylint:
disable=invalid-name
"101": {"filter_name": {"immune": [102, 103]}},
"104": {"filter_name": {"immune": [102, 103]}},
},
+ "native_filter_configuration": [
+ {"scope": {"excluded": ["uuid1", "uuid2"]}}
Review comment:
These should be IDs, not UUIDs.
Also, can we have a new test to check the logic, instead of piggybacking on
`test_update_id_refs_immune_missing`?
##########
File path: superset/dashboards/commands/importers/v1/utils.py
##########
@@ -17,7 +17,7 @@
import json
import logging
-from typing import Any, Dict, Set
+from typing import Any, Callable, Dict, Set, Union
Review comment:
These new imports are not needed, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
