rusackas commented on a change in pull request #18558:
URL: https://github.com/apache/superset/pull/18558#discussion_r801866235
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx
##########
@@ -104,7 +90,12 @@ const FilterTitlePane: React.FC<Props> = ({
);
return (
<TabsContainer>
- <StyledHeader>Filters</StyledHeader>
+ <Dropdown overlay={menu} arrow placement="topLeft" trigger={['hover']}>
+ <StyledAddBox>
+ <div data-test="new-dropdown-icon" className="fa fa-plus" />{' '}
+ <span>{t('Add Filters and Dividers')}</span>
Review comment:
According to [the
rules](https://github.com/apache/superset/wiki/Capitalization-Guidelines) it
should be sentence case. If we want to change the rules, we can do that. But in
the name of expediency, I'd accept @geido's change and adjust the test
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
