michael-s-molina commented on pull request #18576: URL: https://github.com/apache/superset/pull/18576#issuecomment-1035232064
@villebro @zhaoyongjie I rebased the code and worked on supporting multi-tab states for the dashboards. The idea is to add an optional parameter called `tab_id` to the `filter_state` enpoint. The server will generate different keys for different tabs. On the client-side, I'm using a mix of the [Local Storage](https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage) with the [Broadcast Channel API](https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API) to generate the tab ids. Unfortunately, Safari still does not support the native API (will do in a month), so I'm using [broadcast-channel](https://github.com/pubkey/broadcast-channel) for now. As soon as Safari 15.4 is released we can remove the dependency. I'll work on the Explore part now to complete the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
