rusackas commented on a change in pull request #18662:
URL: https://github.com/apache/superset/pull/18662#discussion_r804333468



##########
File path: 
superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -332,6 +333,38 @@ const thumbnailContainerCss = (theme: SupersetTheme) => 
css`
   }
 `;
 
+const BetaBadge = styled.div`

Review comment:
       I guess BetaBadge is OK, but we might want to have something more 
generic than Beta (which seems purposeful). Something like `HighlightLabel`?.

##########
File path: 
superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -332,6 +333,38 @@ const thumbnailContainerCss = (theme: SupersetTheme) => 
css`
   }
 `;
 
+const BetaBadge = styled.div`

Review comment:
       I guess BetaBadge is OK, but we might want to have something more 
generic than Beta (which seems purposeful). Something like `HighlightLabel`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to