geido opened a new pull request #18738: URL: https://github.com/apache/superset/pull/18738
### SUMMARY This PR fixes a problem for which the _cache_timeout_ filter wasn't being saved. It also adds unit tests for similar cases for all the fields of the Chart properties modal. ### BEFORE https://user-images.githubusercontent.com/60598000/154050509-b95fd97d-7a72-4b91-9f8d-8d493ef7b088.mp4 ### AFTER https://user-images.githubusercontent.com/60598000/154050230-67100e71-01dc-44a0-86e8-038dd082dfff.mp4 ### TESTING INSTRUCTIONS 1. Edit the Chart properties 2. Enter the cache_timeout field 3. Save 4. Reopen the modal 5. The cache_timeout field should not be empty ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
