kgabryje commented on a change in pull request #18739:
URL: https://github.com/apache/superset/pull/18739#discussion_r811301049
##########
File path: superset-frontend/plugins/plugin-chart-table/src/Styles.tsx
##########
@@ -40,8 +40,9 @@ export default styled.div`
}
th svg {
color: ${({ theme: { colors } }) => colors.grayscale.light2};
- position: relative;
+ position: absolute;
vertical-align: middle;
+ top: ${({ theme: { gridUnit } }) => gridUnit * 2}px;
Review comment:
Should we add `right: 0`? You can see on the screenshot that the arrows
overlap with the th text on the right. Happened when I made the control panel
wide
<img width="1787" alt="image"
src="https://user-images.githubusercontent.com/15073128/154997348-7c5c28ec-6c4c-4797-a018-a0afcd1adb1d.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/15073128/154997348-7c5c28ec-6c4c-4797-a018-a0afcd1adb1d.png"](https://user-images.githubusercontent.com/15073128/154997348-7c5c28ec-6c4c-4797-a018-a0afcd1adb1d.png"){kind=link}