ktmud commented on a change in pull request #18799:
URL: https://github.com/apache/superset/pull/18799#discussion_r814260270
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -63,12 +62,7 @@ type PickedSelectProps = Pick<
| 'value'
>;
-type OptionsProps = Exclude<AntdSelectAllProps['options'], undefined>;
-
-export interface OptionsType extends Omit<OptionsProps, 'label'> {
- label?: string;
- customLabel?: ReactNode;
-}
Review comment:
The existing check doesn't work already. I was thinking of some bigger
refactoring with the customLabel check so I'd rather keep it in a separate PR.
I can put that PR up first if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
