betodealmeida commented on a change in pull request #18795:
URL: https://github.com/apache/superset/pull/18795#discussion_r817219442
##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -516,11 +517,10 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
}
});
- const shouldEnableForceScreenshot = contentType === 'chart' && !isReport;
const data: any = {
...currentAlert,
type: isReport ? 'Report' : 'Alert',
- force_screenshot: shouldEnableForceScreenshot || forceScreenshot,
+ force_screenshot: !isReport || forceScreenshot, // alerts (!isReport)
should always bypass cache
Review comment:
Wait... for alerts with dashboards we don't want to always bypass the
cache.
##########
File path: superset/reports/commands/execute.py
##########
@@ -173,7 +172,7 @@ def _get_url(
user_friendly=user_friendly,
dashboard_id_or_slug=self._report_schedule.dashboard_id,
standalone=DashboardStandaloneMode.REPORT.value,
- # force=force, TODO (betodealmeida) implement this
Review comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
