betodealmeida opened a new pull request #19055: URL: https://github.com/apache/superset/pull/19055
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR introduces 2 helper functions for RLS: - `has_table_query(statement: Statement) -> bool:`, which analyzes a SQL statement parsed by`sqlparse` and returns `True` if it queries a table (either in a `FROM` or `JOIN`). - `insert_rls(token_list: TokenList, table: str, rls: TokenList) -> TokenList:`, which given a parsed statement (or token list), a table name, and a parsed RLS expression, will reformat the query so that the RLS is present in any queries or subqueries referencing the table. For example, if we have the RLS expression `id=42` on the table `my_table` we could do: ```python >>> statement = sqlparse.parse('SELECT COUNT(*) FROM my_table')[0] >>> has_table_query(statement) True >>> rls = sqlparse.parse('id=42')[0] >>> print(insert_rls(statement, 'my_table', rls) SELECT COUNT(*) FROM my_table WHERE id=42 ``` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> I added unit tests covering different cases. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
