villebro commented on pull request #19078: URL: https://github.com/apache/superset/pull/19078#issuecomment-1069106904
> I tested the PR locally and found one more issue: in the dashboard short link with multiple tabs, when i copy the link from tab2, i got link to the tab1 > > short.link.of.tab2.mov Thanks for catching it @jinghua-qa ! This broke during some cleanup due to the original code being JS (=no type declarations to catch the erroneous function call). This should now be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
