eschutho opened a new pull request #19228:
URL: https://github.com/apache/superset/pull/19228


   
   ### SUMMARY
   We are currently dual writing any updates/additions of the SqlaTable to the 
new Dataset models. We found some errors during update where the new dataset 
should also be updated, but it doesn't exist. I'm not sure if the dataset 
wasn't created because when the migration to backfill was run a new SqlaTable 
was created and we missed it, or we're missing it somewhere else. But for now, 
I'm catching this error and recreating the new dataset if the shadow model 
wasn't created. 
   
   ### TESTING INSTRUCTIONS
   Difficult to reproduce in order to test manually, but I recreated the 
situation in unit tests. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to