eschutho commented on a change in pull request #19083:
URL: https://github.com/apache/superset/pull/19083#discussion_r829604804
##########
File path: tests/integration_tests/model_tests.py
##########
@@ -504,7 +504,7 @@ def test_sql_mutator(self):
sql = tbl.get_query_str(query_obj)
self.assertNotIn("-- COMMENT", sql)
- def mutator(*args):
+ def mutator(*args, **kwargs):
Review comment:
@hughhhh I added one more test to check that the database name is being
passed in. LMK if you think more tests around that would be helpful.
`user_name` was null and the `security_manager` is a function so printing them
wouldn't really validate much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
