yousoph commented on pull request #18968: URL: https://github.com/apache/superset/pull/18968#issuecomment-1073361773
I like the flexibility in overwriting that this would add, thanks @michael-hoffman-26 ! A few thoughts: 1. Agreed with @betodealmeida that it would be great to be consistent and have a similar flow for charts and datasets. 2. Does the "Confirm" on the advanced settings proceed with the import? If so, I'd suggest using text similar to what we currently have on the overwrite prompt in the below screenshot rather than referring to the import file as a config. "Overwriting might cause you to lose some of your work. Are you sure you want to overwrite?" 3. I noticed that if I import an existing dashboard without making selections on the advanced options first, I get into this state, which is confusing :  Could we prompt the user to select only after we know that the file contains objects that already exists? This way, users won't see these options if they don't have any overwrites in their import, and we could do away with the double confirmation that shows up in this screenshot Flow would be: * Select file with no advanced options showing * User starts import * If import doesn't overwrite anything, proceed with the import. * If import does overwrite, then show users the fields in advanced options and allow them to select which objects should be overwritten. Once confirmed, import proceeds. @jess-dillard - curious to hear your thoughts here as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
