geido commented on pull request #19239: URL: https://github.com/apache/superset/pull/19239#issuecomment-1076680441
> I'm worried about the execution time. Even with the suggestion to improve `hasLiteralColor` the time is still high. Here's `npm run _lint` execution times (in minutes:seconds): > > With rule disabled: `1:44` With original rule enabled: `27:41` With code suggestions: `25:54` > > I also found a false positive in `src/visualizations/TimeTable/TimeTable.jsx`. > > Maybe we can invest some time to make it faster? I am looking into the performance and see what we can do. As for the false-positive in `src/visualizations/TimeTable/TimeTable.jsx`, I am not sure why you think it is a false positive. This is what I see at line 247 where it complains. Lmk! > borderRight: '2px solid #fff', -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
