hughhhh commented on a change in pull request #19314:
URL: https://github.com/apache/superset/pull/19314#discussion_r838804873
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -1013,6 +1156,41 @@ const DatabaseModal:
FunctionComponent<DatabaseModalProps> = ({
);
};
+ if (file.length > 0 && importingModel) {
Review comment:
can we refactor the logic not to use `importingModel` and instead
leverage `file`, `confirmedOverwrite`, and `passwords` to dictate the state and
what the modal should show.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
