[GitHub] [superset] prosdev0107 commented on a diff in pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection

[GitBox]

prosdev0107 commented on code in PR #19694:
URL: https://github.com/apache/superset/pull/19694#discussion_r849628208


##########
superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx:
##########
@@ -17,7 +17,8 @@
  * under the License.
  */
 import React from 'react';
-import { Input } from 'antd';
+import { Input, Tooltip } from 'antd';

Review Comment:
   @AAfghahi 
   So you mean that we should create the new PasswordInput superset component 
by splitting Password Input component in `LabeledErrorBoundInput` component?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org