nytai commented on code in PR #19708:
URL: https://github.com/apache/superset/pull/19708#discussion_r850007401
##########
superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts:
##########
@@ -161,7 +163,7 @@ export default class SupersetClientClass {
headers,
timeout,
fetchRetryOptions,
- ignoreUnauthorized,
+ ignoreUnauthorized = false,
Review Comment:
I strongly agree here, this behavior is quite surprising from an api client.
Though I guess this approach involves the least amount of code changes.
From a UX perspective I'd suggest presenting the user with the option to
re-auth. There could be unsaved work that would be lost via a the redirect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
