kgabryje opened a new pull request, #19792: URL: https://github.com/apache/superset/pull/19792
### SUMMARY As a result of changes in PR https://github.com/apache/superset/pull/19039, when user switched query mode in table chart between Aggregate and Raw Records, the controls in currently inactive mode were being reset. This PR fixes that problem by introducing a new prop `resetOnHide`, which is true by default and set to false in table chart controls. Please consider this fix as a temporary solution - we should probably figure out a more sturdy, foolproof solution. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://user-images.githubusercontent.com/15073128/164252120-0641eae7-c268-4fbe-bd3c-9f50cd98656d.mov After: https://user-images.githubusercontent.com/15073128/164252307-2b3af4a7-fd52-40fb-9d87-bca68e81f51a.mov ### TESTING INSTRUCTIONS 1. Open a table chart 2. Add some values to controls in aggregate mode 3. Add some values to controls in raw records mode 4. Switch between the modes a few times, verify that controls are not being reset 5. Run query, verify that values of currently hidden controls are not included in the query ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
