[GitHub] [superset] villebro opened a new pull request, #20055: fix(plugin-chart-echarts): support adhoc x-axis

[GitBox]

villebro opened a new pull request, #20055:
URL: https://github.com/apache/superset/pull/20055

   ### SUMMARY
   Currently using a Custom SQL expression with the `GENERIC_CHART_AXES` 
produces unexpected results. Here we ensure all post processing operations that 
support generic x-axes also support custom SQL adhoc columns. In addition, the 
`transformProps` of the ECharts Timeseries chart is update to properly handle 
custom SQL adhoc columns.
   
   ### AFTER
   Now the chart renders as expected:
   <img width="935" alt="image" 
src="https://user-images.githubusercontent.com/33317356/168270256-0799423e-fe04-4ff4-b586-c2e0e68a6cf9.png";>
   
   ### BEFORE
   Previously the chart data request returned zero rows:
   <img width="923" alt="image" 
src="https://user-images.githubusercontent.com/33317356/168270415-9c0d498c-f89b-4578-9f54-174281ad1701.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org