kgabryje opened a new pull request, #20248:
URL: https://github.com/apache/superset/pull/20248

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   This PR implements the redesign of viz switcher. Now user can quickly change 
viz type to 1 of 6 featured charts without opening the viz gallery modal.
   Active chart is represented by an icon and chart name. If chart's name is 
truncated, then tooltip appears on hover.
   The rest of the featured charts are represented only by a clickable icon. 
Chart's name appears in a tooltip on hover. Clicking the icon switches the viz 
type.
   User can open the viz gallery modal by clicking "View all charts". When user 
selects a chart that is not "featured", it's represented by a magnifying glass 
icon and chart's name. It's placed first on the quick viz switcher list.
   
   Featured charts are:
   - Echarts Line Chart
   - Table
   - Big Number with Trendline
   - Pie Chart
   - Echarts Bar Chart
   - Echarts Area Chart
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
https://user-images.githubusercontent.com/15073128/171687914-94b72ee2-5737-4c0d-8aac-7ee439d900b1.mov
   
   ### TESTING INSTRUCTIONS
   1. Open explore with 1 of the featured charts
   2. Verify that there are 6 icons in viz switcher, the active viz is 
highlighted and its name is visible
   3. Click on any other icon, verify that the control panel now displays 
controls of currently active chart. Click Update Chart and verify that 
everything works as expected
   4. Click "View all charts", change to a non-featured chart
   5. Verify that now there are 7 items in viz switcher list and active 
non-featured chart is 1st on the list. Repeat step 3.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC @kasiazjc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to