eschutho commented on code in PR #20351:
URL: https://github.com/apache/superset/pull/20351#discussion_r894950952
##########
superset/connectors/sqla/utils.py:
##########
@@ -209,9 +212,15 @@ def find_cached_objects_in_session(
if not ids and not uuids:
return iter([])
uuids = uuids or []
+ try:
+ items = set(session)
+ except ObjectDeletedError:
+ logger.warning("ObjectDeletedError", exc_info=True)
+ return iter(())
Review Comment:
this was erroring for me when running integration tests, so I just thought
it would be safe to catch and log the error in case it happens in the real
world.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
