michael-s-molina opened a new pull request, #20399:
URL: https://github.com/apache/superset/pull/20399

   ### SUMMARY
   This PR is part of the Single Page App initiative and it adds the `/explore` 
endpoint to the `v1` API. The previous legacy endpoint in `superset.views.core` 
was responsible not only for assembling the Explore context but also to save 
Explore-related information. This endpoint, however, does not contain any save 
operation. We should use the existing `v1` endpoints to save the charts and 
dashboard relationships. Another important difference is that this endpoint 
does not return shared bootstrap data such as `user`, `permissions`, `common`, 
etc. as these are already available by other means.
   
   The legacy endpoint also contained redirects and flash messages. These were 
transformed into HTTP response errors/values and should be handled by the 
client-side.
   
   Much of the code in the new endpoint comes from the legacy one. It's 
important to mention that it is not the objective of the PR to refactor the 
code at this point to avoid introducing potential regressions. 
   
   ```
   GET /v1/explore/
   
   QUERY PARAMS # all optional
      form_data_key=<key>
      permalink_key=<key>
      slice_id=<id>
      dataset_id=<id>
      dataset_type=<type> 
   
   RESPONSE 
   { 
      form_data: <object>,
      dataset: <object>,
      slice: <object>,
      message: <string> # information related to the request
   }
   
   ```
   We will remove the legacy endpoint after the SPA initiative is completed.
   
   ### TESTING INSTRUCTIONS
   1 - Execute the API tests
   2 - All tests should pass
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to