eschutho commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r904093706
##########
superset/models/sql_lab.py:
##########
@@ -179,6 +232,53 @@ def raise_for_access(self) -> None:
security_manager.raise_for_access(query=self)
+ @property
+ def db_engine_spec(self) -> Type["BaseEngineSpec"]:
+ return self.database.db_engine_spec
+
+ @property
+ def owners_data(self) -> List[Dict[str, Any]]:
+ return []
+
+ @property
+ def metrics(self) -> List[Any]:
+ return []
+
+ @property
+ def uid(self) -> str:
Review Comment:
I asked about the datasource uid on a different PR. I suppose if we go this
route, we'll need to make sure that there aren't duplicate uuids between
datasources, which could be tricky unless we use a prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]