dpgaspar commented on PR #20399: URL: https://github.com/apache/superset/pull/20399#issuecomment-1164164291
> > Can you add unittests for GetExploreCommand also > > Since the API is pretty much invoking the `GetExploreCommand`, with no extra logic, the tests for the command would be very similar. So I chose to just test the API layer because it seemed like the best cost/benefit approach. I understand, my current concern is that the defined response payload is complex and I don't see them been asserted on the API tests, for example `dataset` and `slice` are always asserted has `None`. Can you add tests for them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
