ktmud commented on code in PR #20473:
URL: https://github.com/apache/superset/pull/20473#discussion_r905283470
##########
superset/datasets/dao.py:
##########
@@ -287,24 +296,27 @@ def find_dataset_metric(
return db.session.query(SqlMetric).get(metric_id)
@classmethod
- def delete_metric(
- cls, model: SqlMetric, commit: bool = True
- ) -> Optional[TableColumn]:
Review Comment:
Why does the command still return the metric when it is deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
