codyml commented on PR #20498:
URL: https://github.com/apache/superset/pull/20498#issuecomment-1175367666
> Can we get rid of page refresh when you overwrite the chart? I removed
`window.location.assign(`/explore/?slice_id=${value.id}`);` from
`SaveModal.tsx` and it seems to be working. The only problem is that "altered"
pill doesn't disappear but I think that can be fixed easily by updating
`explore.slice` and/or `charts[chart_id].sliceFormData` (since slice holds the
metadata of saved chart)
>
> Ideally we could also prevent redirecting when saving as a new chart, but
that might be trickier...
Working on this as a separate fix outside of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
