eschutho commented on code in PR #20629:
URL: https://github.com/apache/superset/pull/20629#discussion_r916356381
##########
superset/charts/post_processing.py:
##########
@@ -325,9 +325,16 @@ def apply_post_process(
for query in result["queries"]:
if query["result_format"] == ChartDataResultFormat.JSON:
- df = pd.DataFrame.from_dict(query["data"])
+ try:
+ df = pd.DataFrame.from_dict(query["data"])
+ except ValueError: # no data error
+ return result
Review Comment:
based on @john-bodley's comment, i added a few more tests when data is
`None` and found a case where it errors later in the code, so I put a nullish
check like he suggested instead of the try/except.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
