kgabryje commented on code in PR #20743:
URL: https://github.com/apache/superset/pull/20743#discussion_r925415104
##########
superset-frontend/src/explore/ExplorePage.tsx:
##########
@@ -57,6 +67,58 @@ const fetchExploreData = async (exploreUrlParams:
URLSearchParams) => {
}
};
+const getDashboardContextFormData = () => {
+ const dashboardTabId = getUrlParam(URL_PARAMS.dashboardTabId);
+ const sliceId = getUrlParam(URL_PARAMS.sliceId) || 0;
+ let dashboardContextWithFilters = {};
+ if (dashboardTabId) {
+ const {
+ labelColors,
+ sharedLabelColors,
+ colorScheme,
+ chartConfiguration,
+ nativeFilters,
Review Comment:
It's `state.nativeFilters.filters` (so without filterSets). We use it in
`getFormDataWithExtraFilters` called in line 88. However, now I noticed that we
only need `chartsInScope` for each filter - the rest of metadata is redundant.
Same goes for cross filters (chartConfiguration). I'll change that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
