michael-s-molina commented on code in PR #20842: URL: https://github.com/apache/superset/pull/20842#discussion_r928932598
########## superset-frontend/packages/superset-ui-core/test/utils/lruCache.test.ts: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { lruCache } from '@superset-ui/core'; + +describe('simple LRUCache', () => { + test('initial LRU', () => { + expect(lruCache().capacity).toBe(100); + expect(lruCache(10).capacity).toBe(10); + expect(lruCache(10).size).toBe(0); + expect(() => lruCache(0)).toThrow(Error); + }); + + test('LRU', () => { Review Comment: Here's an example: ``` const newCache = () => { const cache = lruCache<string>(3); cache.set('1', 'a'); cache.set('2', 'b'); cache.set('3', 'c'); return cache; }; test('initial LRU', () => { expect(lruCache().capacity).toBe(100); expect(lruCache(10).capacity).toBe(10); expect(lruCache(10).size).toBe(0); expect(() => lruCache(0)).toThrow(Error); }); test('correctly evicts LRU value', () => { const cache = newCache(); expect(cache.size).toBe(3); cache.set('4', 'd'); expect(cache.has('1')).toBeFalsy(); expect(cache.get('1')).toBeUndefined(); }); test('correctly updates LRU value', () => { const cache = newCache(); cache.get('1'); cache.set('5', 'e'); expect(cache.has('1')).toBeTruthy(); expect(cache.has('2')).toBeFalsy(); }); test('throws exception when key is invalid', () => { const cache = lruCache<string>(3); // @ts-ignore expect(() => cache.set(0)).toThrow(TypeError); }); test('clears the cache', () => { const cache = newCache(); cache.clear(); expect(cache.size).toBe(0); expect(cache.capacity).toBe(3); }); ``` This way, when a test fails, it's easier to identify what parts of the code are broken. It also avoids state dependencies between different test cases. You can reuse an initial state or optimize for each test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
