[GitHub] [superset] michael-s-molina commented on pull request #20728: [WIP] feature(dashboard): Drill to detail modal

Mon, 25 Jul 2022 11:16:15 -0700 


michael-s-molina commented on PR #20728:
URL: https://github.com/apache/superset/pull/20728#issuecomment-1194438712

   Hi @codyml. We need to account for charts and dashboard configurations when 
displaying the drilling details panel. One example is the chart below:
   
   <img width="1779" alt="Screen Shot 2022-07-25 at 2 56 01 PM" 
src="https://user-images.githubusercontent.com/70410625/180842990-77c4957c-90b6-4b03-9d10-c68657cd99b0.png";>
   
   In this chart, we should consider the controls configuration that impacts 
the query like `is_software_dev = 1`, `last_yr_income <= 200000`, and `time 
range = 2018-03-01 <= col < 2022-07-25`. We also need consider that each 
visualization has different controls.
   
   I believe the samples pane in Explore should also account for these filters. 
If I set `is_software_dev = 1` I don't expect to see samples where this 
condition is not true.
   
   The drilling details panel should also be influenced by dashboard 
configurations like `developer_type` in the example below:
   
   <img width="1767" alt="Screen Shot 2022-07-25 at 3 03 58 PM" 
src="https://user-images.githubusercontent.com/70410625/180844347-fe3095d0-88ce-410f-8c64-3c708205fbd3.png";>
   
   To make things more complicated, dashboard filters can come from the filters 
panel or cross-filters.
   
   I don't know if I covered everything. We may have other sources that impact 
a chart. Tagging some folks to see if I'm missing anything @rusackas 
@lauderbaugh @zhaoyongjie @kgabryje @geido 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to