michael-s-molina opened a new pull request, #20891:
URL: https://github.com/apache/superset/pull/20891

   ### SUMMARY
   Adds drill to detail (drill-through) context menu for ECharts 
visualizations. The context menu is triggered when right-clicking an EChart 
series. Upon selecting a drill to detail option, an alert is displayed with the 
selected values.
   
   The linking between the context menu and the actual feature will be handled 
in a future PR.
   
   The context menu was added to all ECharts with the exception of the Tree 
Chart.
   
   The feature is behind the `DRILL_TO_DETAIL` feature flag.
   
   This first iteration focuses on providing a minimal set of interaction 
possibilities for the ECharts. More advanced interactions like clicking on 
legends, subheaders, etc will be handled in follow-up PRs. Drilling to detail 
using metrics is not supported as well.
   
   @kasiazjc @lauderbaugh @rusackas @codyml 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/181340086-a6a8376f-e962-440c-b5f4-8679bc731337.mov
   
   ### TESTING INSTRUCTIONS
   
   1 - Make sure the feature does not introduce any regression when disabled. 
This is the default value for the feature flag.
   
   2 - Enable the `DRILL_TO_DETAIL` feature flag and check:
   - Check if there are no regressions when right-clicking the series for 
different charts
   - Check if the right-click works with different chart control values 
(dimensions, time grain, customizations, etc)
   - Check if the correct values are displayed in the context menu
   - Check if the correct values are displayed when selecting a context menu 
option
   - Check if other dashboard interactions are not affected by the new feature 
such as cross-filtering, drag-and-drop, tooltips, etc
   
   Below is the import file for the dashboard shown in the video:
   
[dashboard_export_20220727T144027.zip](https://github.com/apache/superset/files/9202425/dashboard_export_20220727T144027.zip)
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Required feature flags: `DRILL_TO_DETAIL`
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to