jess-dillard commented on PR #20876: URL: https://github.com/apache/superset/pull/20876#issuecomment-1198458819
Hi all, thanks for the great work on this! I have a few UX/UI suggestions that would better align with Superset's current patterns. **Edit properties modal** Instead of putting the applied tags to the right of the tag selection field, I would use the multi-select component and keep the tags inside the bounds of the field (like the multi-select filter field in dashboards): <img width="250" alt="Screen Shot 2022-07-28 at 10 49 11 AM" src="https://user-images.githubusercontent.com/90715511/181603984-0c910a36-fbcc-4024-a976-59a57c953984.png";> **Tags view** I would actually create two views here to properly utilize and manage tags. 1. Tags CRUD A Tags page, accessible from the global settings menu, that uses the existing CRUD template to display all tags. Columns in the table could include how many entities are tagged, who created it, etc. This is where the user would manage (edit/add/delete) tags. 2. "All entities" view To satisfy the need to see all entities with a certain tag applied, I would create another CRUD view that combines dashboards/charts/queries and allows the user to filter by tags. This could be accessible from the main navigation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/90715511/181603984-0c910a36-fbcc-4024-a976-59a57c953984.png"](https://user-images.githubusercontent.com/90715511/181603984-0c910a36-fbcc-4024-a976-59a57c953984.png"){kind=link}