[GitHub] [superset] diegomedina248 opened a new pull request, #21096: fix: users without write dataset permission can create datasets on sql lab

[GitBox]

diegomedina248 opened a new pull request, #21096:
URL: https://github.com/apache/superset/pull/21096

   ### SUMMARY
   
   A user without write dataset permissions can still create datasets from SQL 
Lab.
   Gamma users with sql lab permissions for instance.
   
   This PR prevents it at the API level and also removes the possibility on the 
frontend.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   <img width="1728" alt="Screen Shot 2022-08-16 at 00 37 47" 
src="https://user-images.githubusercontent.com/17252075/184792880-9e7dd022-997c-471a-95e6-6eb396687c52.png";>
   
   
   After:
   
   <img width="1728" alt="Screen Shot 2022-08-16 at 00 37 30" 
src="https://user-images.githubusercontent.com/17252075/184792854-cfa6d7c3-c5c1-43b0-9c7f-6269125aaecb.png";>
   
   Users with the write permission will still see the UI as the "Before" 
picture.
   
   ### TESTING INSTRUCTIONS
   
   1. Log in with a gamma with sql lab user role
   2. Create a dataset from SQL Lab and save it
   3. Go to datasets page
   4. Can’t see the “Action” column to modify the dataset
   5. Open the dataset in Chart Builder mode
   6. Edit dataset from here
   7. Not able to save changes with message, “Access is Denied”
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org