[GitHub] [superset] kgabryje opened a new pull request, #21101: fix(plugin-chart-table): Upgrade old color formats

[GitBox]

kgabryje opened a new pull request, #21101:
URL: https://github.com/apache/superset/pull/21101

   
   ### SUMMARY
   First version of table conditional formatter was using `rgb()` format to 
describe colors. Later we changed it to hex notation, which broke the existing 
color formatters. This PR adds a migration of old color formatters to use hex 
notation.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="1792" alt="Screenshot 2022-08-16 at 16 27 48" 
src="https://user-images.githubusercontent.com/15073128/184908332-0fffde67-769a-41b4-b6e5-a888728cc83f.png";>
   
   
   After:
   <img width="1792" alt="Screenshot 2022-08-16 at 16 25 02" 
src="https://user-images.githubusercontent.com/15073128/184908276-1ecccb7a-3dff-4d9e-b953-79e486911c9e.png";>
   
   ### TESTING INSTRUCTIONS
   1. Open a table chart with conditional formatters using the old color 
formats (or just manually edit the form data in the database with 1 of 
`rgb(255,0,0)` for red, `rgb(255,255,0)` for yellow or `rgb(0,255,0)` for green.
   2. Run the migration
   3. Verify that the conditional formatters apply colors correctly
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org