justinpark opened a new pull request, #21105:
URL: https://github.com/apache/superset/pull/21105

   ### SUMMARY
   This commit fixes the cypress specs for sqllab query by updating selectors 
and network interceptors.
   This commit also includes all api mock response in fixtures folder.
   The spec will interactive with the fake interceptors rather than real 
network interaction.
   It will inspect the request payload/formdata for network request.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
https://user-images.githubusercontent.com/1392866/185002049-34afed2b-bf57-4f2a-b626-30073ac7a2c1.mov
   
   ### TESTING INSTRUCTIONS
   cypress
   
   ```
   cd superset-frontend/cypress-base
   yarn cypress
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to