eschutho commented on code in PR #21095: URL: https://github.com/apache/superset/pull/21095#discussion_r948527370
########## .github/workflows/chromatic.yml: ########## @@ -0,0 +1,56 @@ +# .github/workflows/chromatic.yml +# seee https://www.chromatic.com/docs/github-actions + +# Workflow name +name: 'Chromatic' + +# Event for the workflow +# Only run if changes were made in superset-frontend folder of repo +on: + push: + branches: + - master + paths: + - "superset-frontend/**" + pull_request_target: + types: [opened, edited, synchronize, reopen] + paths: + - "superset-frontend/**" + +env: + CHROMATIC_PROJECT_TOKEN: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} Review Comment: ~~Oh, I don't think you need this here. It will already be available in env.~~ After reading through, I see what you're doing here. This may work, but I usually just put the secret in the job itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
