villebro commented on PR #21143: URL: https://github.com/apache/superset/pull/21143#issuecomment-1229827706
@sinhashubham95 just so I understand this PR correctly, are we essentially copying over the functions from `just-handlebar-helpers`? While it may make it possible to drop some unnecessary requirements, we're already pulling in `moment` as it's needed elsewhere, so dropping `just-handlebars-helpers` won't remove that dependency. Also, I notice the lock file hasn't been updated, so we'd at least need to rebuild the main `package-lock.json` file which appears to still be referencing `just-handlebars-helpers`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
