kristw commented on a change in pull request #6973: add chart export png
URL:
https://github.com/apache/incubator-superset/pull/6973#discussion_r262212705
##########
File path: superset/assets/src/explore/components/ExploreActionButtons.jsx
##########
@@ -24,23 +24,25 @@ import { t } from '@superset-ui/translation';
import URLShortLinkButton from '../../components/URLShortLinkButton';
import EmbedCodeButton from './EmbedCodeButton';
import DisplayQueryButton from './DisplayQueryButton';
-import { exportChart, getExploreLongUrl } from '../exploreUtils';
+import { exportChart, getExploreLongUrl, exportChartPNG} from
'../exploreUtils';
const propTypes = {
actions: PropTypes.object.isRequired,
canDownload: PropTypes.oneOfType([PropTypes.string,
PropTypes.bool]).isRequired,
chartStatus: PropTypes.string,
latestQueryFormData: PropTypes.object,
queryResponse: PropTypes.object,
+ slice: propTypes.slice
Review comment:
This is referring to itself.
Please check `prop-types` reference on how to define a proper prop type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
