justinpark commented on code in PR #21262:
URL: https://github.com/apache/superset/pull/21262#discussion_r958995057
##########
superset/views/core.py:
##########
@@ -1202,11 +1202,8 @@ def is_match(src: str, target: utils.DatasourceName) ->
bool:
max_items = config["MAX_TABLE_NAMES"] or len(tables)
total_items = len(tables) + len(views)
- max_tables = len(tables)
- max_views = len(views)
- if total_items and substr_parsed:
- max_tables = max_items * len(tables) // total_items
- max_views = max_items * len(views) // total_items
+ max_tables = max_items or len(tables)
Review Comment:
@john-bodley you're right. it used to allow the empty `schema_parsed` option
before (#1466) but no longer allowed as far as the current FE logic exists.
And `MAX_TABLE_NAMES` never invoked since `substr_parsed` is never truthy.
I hope to restore `MAX_TABLE_NAMES` option to fix our edge cases (>100k).
I posted updates to make `max_items` = max_tables + max_views
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
